Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream devtools commit #6000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

irvinebroque
Copy link
Contributor

@irvinebroque irvinebroque commented Jun 10, 2024

refs EW-8447

Haven't updated since 2023. See if this works on preview build

Haven't updated since 2023
Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: b6439aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-wrangler-6000

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6000/npm-package-wrangler-6000

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-wrangler-6000 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-create-cloudflare-6000 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-cloudflare-kv-asset-handler-6000
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-miniflare-6000
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-cloudflare-pages-shared-6000
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9451695971/npm-package-cloudflare-vitest-pool-workers-6000

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240605.0
workerd 1.20240605.0 1.20240605.0
workerd --version 1.20240605.0 2024-06-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin marked this pull request as ready for review June 13, 2024 20:02
@petebacondarwin petebacondarwin requested a review from a team as a code owner June 13, 2024 20:02
@threepointone
Copy link
Contributor

Wanna land this?

@petebacondarwin
Copy link
Contributor

@penalosa is the knowledge leader here. Let's wait for him to take a look on Monday.

@irvinebroque
Copy link
Contributor Author

We need EW-8447 to be addressed first — get inspector bits working first, then test it out with this change. See internal.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also requires changes to the devtools patches to unhide the perfomance tab (pending internal work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

None yet

4 participants