Add a test for Workers SDK issue #2166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Just in case it's helpful, here are the tests passing on my machine:
|
The issue: cloudflare/workers-sdk#3160 The test is passing and it is proof of the expected behavior that Workers SDK doesn't match.
12 tasks
mikea
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't meant to be merged, yet it might be useful depending on how the maintainers would like to approach the problem.
I opened it because of the Workers SDK issue, which causes unexpected behavior of
JOINwith the same column names that I'm trying to fix. I need proof of the behavior, and hopefully, this PR will allow me to demonstrate the passing test result.The Workers SDK issue: cloudflare/workers-sdk#3160
A Workers SDK PR with a similar test that is failing: cloudflare/workers-sdk#5917