Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Remove old storage/view public API endpoint #3895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[api] Remove old storage/view public API endpoint #3895

wants to merge 1 commit into from
+5 −12

Conversation

Harshg999
Copy link
Collaborator

What changes were proposed in this pull request?

  • This endpoint is not required now because we have introduced /stats, /display, /list public API endpoints.

How was this patch tested?

  • Manually

@Harshg999 Harshg999 self-assigned this Nov 28, 2024
@github-actions GitHub Actions
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

ramprasadagarwal
ramprasadagarwal approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The endpoints are also removed from frontend, so it is good to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramprasadagarwal ramprasadagarwal ramprasadagarwal approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@bjornalm bjornalm Awaiting requested review from bjornalm

@ranade1 ranade1 Awaiting requested review from ranade1

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@agl29 agl29 Awaiting requested review from agl29

At least 2 approving reviews are required to merge this pull request.

Assignees

@Harshg999 Harshg999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harshg999 @ramprasadagarwal