Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce GCP xaccount SA policies #76

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/terraform-cdp-gcp-pre-reqs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ In each directory an example `terraform.tfvars.sample` values file is included t
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | > 1.3.0 |
| <a name="requirement_google"></a> [google](#requirement\_google) | 4.84.0 |
| <a name="requirement_random"></a> [random](#requirement\_random) | 3.4.3 |
| <a name="requirement_random"></a> [random](#requirement\_random) | ~> 3.4.3 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_google"></a> [google](#provider\_google) | 4.84.0 |
| <a name="provider_random"></a> [random](#provider\_random) | 3.4.3 |
| <a name="provider_random"></a> [random](#provider\_random) | ~> 3.4.3 |

## Modules

Expand Down Expand Up @@ -63,7 +63,7 @@ In each directory an example `terraform.tfvars.sample` values file is included t
| [google_storage_bucket_iam_member.cdp_data_sa_member](https://registry.terraform.io/providers/hashicorp/google/4.84.0/docs/resources/storage_bucket_iam_member) | resource |
| [google_storage_bucket_iam_member.cdp_log_sa_member](https://registry.terraform.io/providers/hashicorp/google/4.84.0/docs/resources/storage_bucket_iam_member) | resource |
| [google_storage_bucket_iam_member.cdp_ranger_audit_sa_member](https://registry.terraform.io/providers/hashicorp/google/4.84.0/docs/resources/storage_bucket_iam_member) | resource |
| [random_id.bucket_suffix](https://registry.terraform.io/providers/hashicorp/random/3.4.3/docs/resources/id) | resource |
| [random_id.bucket_suffix](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/id) | resource |
| [google_project.project](https://registry.terraform.io/providers/hashicorp/google/4.84.0/docs/data-sources/project) | data source |

## Inputs
Expand Down Expand Up @@ -106,7 +106,7 @@ In each directory an example `terraform.tfvars.sample` values file is included t
| <a name="input_subnet_count"></a> [subnet\_count](#input\_subnet\_count) | Number of Subnets Required | `number` | `1` | no |
| <a name="input_vpc_cidr"></a> [vpc\_cidr](#input\_vpc\_cidr) | VPC CIDR Block | `string` | `"10.1.0.0/19"` | no |
| <a name="input_vpc_name"></a> [vpc\_name](#input\_vpc\_name) | VPC name | `string` | `null` | no |
| <a name="input_xaccount_sa_policies"></a> [xaccount\_sa\_policies](#input\_xaccount\_sa\_policies) | List of IAM policies to apply to the Cross Account Service Account | `list(string)` | <pre>[<br> "roles/compute.instanceAdmin.v1",<br> "roles/compute.networkAdmin",<br> "roles/compute.securityAdmin",<br> "roles/compute.imageUser",<br> "roles/compute.storageAdmin",<br> "roles/runtimeconfig.admin",<br> "roles/cloudkms.admin",<br> "roles/owner"<br>]</pre> | no |
| <a name="input_xaccount_sa_policies"></a> [xaccount\_sa\_policies](#input\_xaccount\_sa\_policies) | List of IAM policies to apply to the Cross Account Service Account | `list(string)` | <pre>[<br> "roles/iam.serviceAccountUser",<br> "roles/compute.instanceAdmin.v1",<br> "roles/storage.admin",<br> "roles/compute.networkViewer",<br> "roles/compute.loadBalancerAdmin",<br> "roles/cloudsql.admin",<br> "roles/compute.networkUser",<br> "roles/compute.publicIpAdmin",<br> "roles/cloudkms.admin"<br>]</pre> | no |
| <a name="input_xaccount_service_account_name"></a> [xaccount\_service\_account\_name](#input\_xaccount\_service\_account\_name) | Cross Account service account name | `string` | `null` | no |

## Outputs
Expand Down
15 changes: 8 additions & 7 deletions modules/terraform-cdp-gcp-pre-reqs/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,15 @@ variable "xaccount_sa_policies" {
description = "List of IAM policies to apply to the Cross Account Service Account"

default = [
"roles/iam.serviceAccountUser",
"roles/compute.instanceAdmin.v1",
"roles/compute.networkAdmin",
"roles/compute.securityAdmin",
"roles/compute.imageUser",
"roles/compute.storageAdmin",
"roles/runtimeconfig.admin",
"roles/cloudkms.admin",
"roles/owner"
"roles/storage.admin",
"roles/compute.networkViewer",
"roles/compute.loadBalancerAdmin",
"roles/cloudsql.admin",
"roles/compute.networkUser",
"roles/compute.publicIpAdmin",
"roles/cloudkms.admin"
]

}
Expand Down
Loading