Add terraform-aws-proxy module #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
jimright
force-pushed
the
feature/aws_proxy_module
branch
from
0eda895
to
22487ab
Compare
wmudge
requested changes
Dec 15, 2023
| aws_key_pair = "<ENTER_VALUE>" # Change this with the name of a pre-existing AWS keypair, e.g. my-keypair | ||
|
|
||
| # ------- Proxy settings ------- | ||
| ingress_extra_cidrs = "<ENTER_VALUE>" # Any additional CIDRs the Proxy Security Groups for SSH access |
There was a problem hiding this comment.
This needs to be a list of string, i.e. ["10.10.0.45/32"]
There was a problem hiding this comment.
Good spot, thanks Webster. I've fixed this in commit fefb40c.
Signed-off-by: Jim Enright <[email protected]>
wmudge
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module for creation Squid Proxy auto-scaling EC2 instances and Network Load Balancer.
This module can be used to assist in deploying Cloudera Data Platform (CDP) Public Cloud in a fully private networking configuration where a CDP VPC and Networking VPC are connected using the Transit Gateway with the proxy running in the Networking VPC .