Improve subnet CIDR calculation #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimright
requested changes
Aug 7, 2023
There was a problem hiding this comment.
@balazsgaspar - thanks for taking care of this.
Just a small change required to add the new variables to the top-level pre-req module so that they are exposed to the user.
Also can you run terraform fmt -recursive to format all Terraform source files. The GitHub actions are failing on this.
…n added to CDP deployment module
…n added to CDP deployment module
Done! |
jimright
approved these changes
Aug 16, 2023
|
@balazsgaspar - this PR is all tested and ready to be merged. However the merge is blocking as we need DCO signoff is needed on all commits. Details of how to do this are at: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
|
Closing without merging as functionality was added as part of #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the prereq modules configure the vpc/cnet submodules in a way that the total VPC/VNet CIDR range is split up equally between the number of subnets created.
While this is a sound approach, it results in a networking layout that does not align with our recommended network settings (and the current "Create new VPC" feature of CDP) and may be a source of confusion. See also https://docs.cloudera.com/cdp-public-cloud/cloud/requirements-aws/topics/mc-aws-req-vpc.html
We should implement a logic where the user can select the size of the public/private (internal/gateway) subnets and the module calculates each subnet's CIDR range accordingly.
Defaults subnet sizes will be set according to the linked documentation (/19 for internal/private and /24 for public/CDP subnets)