Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure pre-reqs module and refactor for CDP deploy modules #20

Conversation

jimright
Copy link
Contributor

@jimright jimright commented Jun 28, 2023

  • Added a module terraform-cdp-azure-pre-reqs for the creation of the pre-requisite Azure cloud resources
  • Added a module terraform-cdp-deploy to handle the deployment of Cloudera Data Platform (CDP) Public Cloud environment and Datalake creation
  • Refactored the terraform-cdp-aws-pre-reqs module to move the CDP creation to the new terraform-cdp-deploy module.

NOTE: CDP deployment is still carried out via Ansible Playbooks and the cloudera.cloud Ansible collections.

Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
@jimright jimright added the enhancement New feature or request label Jun 28, 2023
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried running modules/terraform-cdp-aws-pre-reqs/examples/ex01-minimal_inputs and it failed. I filled out the terraform.tfvars as required.

wmudge@wmudge-mbp16-21580:~/tmp/2021-07-13/terraform-cdp-modules/modules/terraform-cdp-aws-pre-reqs/examples/ex01-minimal_inputs % terraform apply                                         [pr-20] [10302] 14:41:28
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 26, in module "ex01_minimal_inputs":
│   26:   aws_key_pair = var.aws_key_pair
│ 
│ An argument named "aws_key_pair" is not expected here.
╵

@jimright
Copy link
Contributor Author

Tried running modules/terraform-cdp-aws-pre-reqs/examples/ex01-minimal_inputs and it failed. I filled out the terraform.tfvars as required.

wmudge@wmudge-mbp16-21580:~/tmp/2021-07-13/terraform-cdp-modules/modules/terraform-cdp-aws-pre-reqs/examples/ex01-minimal_inputs % terraform apply                                         [pr-20] [10302] 14:41:28
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 26, in module "ex01_minimal_inputs":
│   26:   aws_key_pair = var.aws_key_pair
│ 
│ An argument named "aws_key_pair" is not expected here.
╵

Hi @wmudge,

Apologies, I had not updated the examples for the terraform-cdp-aws-pre-reqs module on its own. This is done now and ready for re-test.

@jimright jimright requested a review from wmudge July 13, 2023 20:40
@rsuplina
Copy link

I have tested the AWS part of the examples, works on my side.
I'm waiting for the permissions from Service desk to test the Azure example

@jimright jimright merged commit c0c6e79 into cloudera-labs:main Jul 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants