Update test_evaluation to include utterly invalid nodes

This assures that `true ? 6 : invalid` and `false ? invalid : 7` never evaluate the invalid nodes.
cloud-custodian · May 23, 2024 · bd2a68f · bd2a68f
1 parent 59e902d
commit bd2a68f
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/tests/test_evaluation.py b/tests/test_evaluation.py
@@ -501,25 +501,22 @@ def mock_left_expr_tree():
                     lark.Token(type_="INT_LIT", value="6"),
                 ]
             ),
-            lark.Tree(
-                data='literal',
-                children=[
-                    lark.Token(type_="INT_LIT", value="7"),
-                ]
-            ),
+            sentinel.DO_NOT_EVALUATE  # Test will crash if this is evaluated
         ],
         meta=Mock(line=1, column=1)
     )
     return tree
 
 
 def test_eval_expr_3_left_good(mock_left_expr_tree):
+    """Assert ``true ? 6 : invalid`` does not execute the invalid expression."""
     activation = Mock()
     evaluator = Evaluator(
         mock_left_expr_tree,
         activation
     )
     assert evaluator.evaluate() == celtypes.IntType(6)
+    # assert did not crash; therefore, invalid node not touched
 
 
 def test_eval_expr_3_bad_override(mock_left_expr_tree):
@@ -545,12 +542,7 @@ def mock_right_expr_tree():
                     lark.Token(type_="BOOL_LIT", value="false"),
                 ]
             ),
-            lark.Tree(
-                data='literal',
-                children=[
-                    lark.Token(type_="INT_LIT", value="6"),
-                ]
-            ),
+            sentinel.DO_NOT_EVALUATE,  # Test will crash if this is evaluated
             lark.Tree(
                 data='literal',
                 children=[
@@ -563,12 +555,14 @@ def mock_right_expr_tree():
     return tree
 
 def test_eval_expr_3_right_good(mock_right_expr_tree):
+    """Assert ``false ? invalid : 7`` does not execute the invalid expression."""
     activation = Mock()
     evaluator = Evaluator(
         mock_right_expr_tree,
         activation
     )
     assert evaluator.evaluate() == celtypes.IntType(7)
+    # assert did not crash; therefore, invalid node not touched
 
 
 def test_eval_expr_0():