Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLJS-3418: Some Closure libraries are not lowered because they declare es8 (instead of just es6) in deps.js for Google Closure Library #233

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

swannodette
Copy link
Member

No description provided.

…e (instead of just ) in deps.js for Google Closure Library
@swannodette swannodette merged commit d44c56b into master Aug 28, 2024
7 checks passed
@@ -251,6 +252,7 @@
:ecmascript5-strict CompilerOptions$LanguageMode/ECMASCRIPT5_STRICT
:ecmascript6 CompilerOptions$LanguageMode/ECMASCRIPT_2015 ;; (deprecated and remapped)
:ecmascript6-strict CompilerOptions$LanguageMode/ECMASCRIPT_2015 ;; (deprecated and remapped)
:ecmasscript8 CompilerOptions$LanguageMode/ECMASCRIPT_2017
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed thanks!

cooljeanius pushed a commit to cooljeanius/clojurescript that referenced this pull request Nov 19, 2024
…e (instead of just ) in deps.js for Google Closure Library (clojure#233)

Co-authored-by: yardwerkz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants