Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Closure to v20230802 #221

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Bump Closure to v20230802 #221

merged 6 commits into from
Feb 20, 2024

Conversation

swannodette
Copy link
Member

No description provided.

@thheller
Copy link
Contributor

FWIW I reverted the closure-compiler bump in shadow-cljs, due to it no longer compiling a couple packages that worked before. See thheller/shadow-cljs#1170

Didn't have any issues compiling CLJS code though, so doesn't affect regular CLJS so much. Only really an issue for some npm packages. Another problem in that release was google/closure-compiler#4151, which appears to be fixed in master, but has no release yet. I think skipping the v20231112 release is fine.

Also the breakage here is due to them renaming stuff once again, and a few leftover places renaming "modules" to "chunks". So, compileModules becomes compileChunks. Always fun ...

@swannodette
Copy link
Member Author

swannodette commented Feb 19, 2024

@thheller if we bump to v20231112 I'm assuming that will causes annoyances for shadow?

@thheller
Copy link
Contributor

It might yeah.

Usually shadow-cljs was a bit ahead, so that would get auto-picked by the usual conflict resolution. If CLJS itself is newer that will break, if people don't set up their exclusions correctly. Mostly will affect project.clj and deps.edn users, as shadow-cljs.edn itself guards against that.

@swannodette
Copy link
Member Author

@thheller ok, that's undesirable. I'll downgrade before merging this.

@swannodette swannodette changed the title bump Closure to v20231112 bump Closure to v20230802 Feb 19, 2024
@swannodette swannodette changed the title bump Closure to v20230802 Bump Closure to v20230802 Feb 19, 2024
@swannodette swannodette merged commit 3d110e4 into master Feb 20, 2024
7 checks passed
@swannodette swannodette deleted the bump-gcc-2024 branch August 28, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants