* :binding :shadow can be nil

* basic let tests
clojure · Oct 25, 2024 · fd5b19f · fd5b19f
1 parent 2a8db4d
commit fd5b19f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/test/clojure/cljs/analyzer/spec_tests.clj b/src/test/clojure/cljs/analyzer/spec_tests.clj
@@ -23,15 +23,11 @@
 
 (deftest test-let
   (is (s/valid? ::a/node (analyze ns-env '(let []))))
-  ;(is (s/valid? ::a/node (analyze ns-env '(let [x 1]))))
-  ;(is (s/valid? ::a/node (analyze ns-env '(let [x 1] x))))
-  )
+  (is (s/valid? ::a/node (analyze ns-env '(let [x 1]))))
+  (is (s/valid? ::a/node (analyze ns-env '(let [x 1] x)))))
 
 (comment
 
   (test/run-tests)
 
-  ;; next, problem - some fields are nil
-  (s/explain ::a/node (analyze ns-env '(let [x 1])))
-
   )
diff --git a/src/test/clojure/cljs/analyzer/specs.cljc b/src/test/clojure/cljs/analyzer/specs.cljc
@@ -31,7 +31,9 @@
   #{:arg :catch :fn :let :letfn :loop :field})
 (s/def ::variadic? boolean?)
 (s/def ::init ::node)
-(s/def ::shadow ::node)
+(s/def ::shadow
+  (s/or :nil nil?
+        :node ::node))
 
 (defmethod node :binding [_]
   (s/merge