Skip to content

Commit

Permalink
Make sphinx version in sync with the conda package
Browse files Browse the repository at this point in the history 
Keep sphinx version in sync with the conda package
https://github.com/conda-forge/sphinx-click-feedstock
  • Loading branch information
@williamjamir @stephenfin
williamjamir authored and stephenfin committed Oct 10, 2019
1 parent 55633c1 commit 0e089e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion requirements.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pbr>=2.0
sphinx>=1.5,<2.3
sphinx>=1.5,<3.0

4 comments on commit 0e089e4

@ojob
Copy link

@ojob ojob commented on 0e089e4 Nov 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried to install sphinx-click extension, but as latest release of this extension is 2.3.0 while sphinx is now in version 2.2.1, pip refuses to install.
--> could you please release this commit to PYPI ? Thanks !

(I could just write pip install sphinx-click --force for my local machine, however this is not going to work on Gitlab-CI.)

@stephenfin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you mixing up sphinx and sphinx-click? They're different packages with different versions.

@ojob
Copy link

@ojob ojob commented on 0e089e4 Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'm indeed trying to install sphinx-click so that sphinx can use it.

In Pypi, the versions are currently as follows:

  • sphinx version is 2.2.1
  • sphinx-click is 2.3.0, and requires sphinx>=1.5,<2.2

Which means that pip will refuse to install sphinx-click. I want to install from Pypi directly, so that I can embed these packages in Gitlab CI/CD, where tuning packages repos is no fun.

Therefore, I kindly request a release of current commit, so that everything becomes easier :)

(I should have commented on parent commit 55633c1 to make my request clearer, sorry)

@stephenfin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Tag 2.3.1 pushed. Travis should have the release done in the next few minutes.

Please sign in to comment.