Update Mem.h #136
Open
Update Mem.h #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few things in your C++ code that can cause errors or be potentially dangerous. --------------------------------------------------------------------------- Here are the corrections I've made: Added ```#include <cstring>``` for memcpy and memset functions. Use ```size_t``` instead of ```int``` for dimensions to conform to C++ standard definitions. Fixed ```MemCopy``` functions to avoid overloading with identical parameters. Added type conversions to work correctly with pointers. Fixed pointer incrementing operations after writing operations. Added ```BYTE``` and ```DWORD``` type declarations and constants for ```OP_JMP``` and ```OP_CALL``` opcodes.
x87
force-pushed
the
master
branch
5 times, most recently
from
1e46701
to
50df696
Compare
MiranDMC
reviewed
Jun 11, 2024
| using BYTE = unsigned char; | ||
| using DWORD = unsigned long; | ||
|
|
||
| constexpr BYTE OP_JMP = 0xE9; |
There was a problem hiding this comment.
It doesn't build in current project settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things in your C++ code that can cause errors or be potentially dangerous. --------------------------------------------------------------------------- Here are the corrections I've made:
Added
#include <cstring>for memcpy and memset functions. Usesize_tinstead ofintfor dimensions to conform to C++ standard definitions. FixedMemCopyfunctions to avoid overloading with identical parameters. Added type conversions to work correctly with pointers. Fixed pointer incrementing operations after writing operations. AddedBYTEandDWORDtype declarations and constants forOP_JMPandOP_CALLopcodes.