Upgrade Azure Storage SDK to a modern version #629
Conversation
| const properties = await this.queueClient.getProperties() | ||
| return { count: properties.approximateMessagesCount } |
There was a problem hiding this comment.
This likely applies in other places as well. In the original code, error handling logged the error. In the new code, it appears that error handling depends on how await handles exceptions instead of using try and catch blocks to log the error in the same way as the original.
| const properties = await this.queueClient.getProperties() | |
| return { count: properties.approximateMessagesCount } | |
| try { | |
| const properties = await this.queueClient.getProperties() | |
| return { count: properties.approximateMessagesCount } | |
| } catch (error) { | |
| this.logger.error(error) // Log the error | |
| return null // Handle the error by returning null | |
| } |
There was a problem hiding this comment.
Yeah it's a good point. There was one more place like this, I've updated it as well.
| if (connectionString) { | ||
| this.client = QueueServiceClient.fromConnectionString(connectionString, pipelineOptions) | ||
| } else { | ||
| this.client = new QueueServiceClient( |
There was a problem hiding this comment.
This is a nice update here for maintaining the old approach and setting up a more flexible long term approach.
| const retryOperations = new AzureStorage.ExponentialRetryPolicyFilter() | ||
| this.client = AzureStorage.createQueueService(connectionString).withFilter(retryOperations) | ||
| constructor(connectionString, options) { | ||
| const pipelineOptions = { |
There was a problem hiding this comment.
I like the use of pipelineOptions. Makes it easier to see the configs related to the queues.
| } | ||
|
|
||
| // This API can only be used for the 'deadletter' store because we cannot look up documents by type performantly | ||
| async count(type, force = false) { |
There was a problem hiding this comment.
Can you talk about the reason this is deleted completely?
There was a problem hiding this comment.
It was an oversight, I've brought it back. Thanks for catching it!
This change is a prerequisite to enable token-based authentication for the Azure Storage operations (blobs and queues). This change leaves the options to use the existing, connection string-based authentication though.