-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Facebook authentication support #26
base: master
Are you sure you want to change the base?
Conversation
Hi @rushidesai and thanks for the PR! I'm not sure I want to merge it, though... I'd like to maintain the "core" as simple as possible (and you know that those authentication models can break, in the future), using - for now - only the Google login as the "external" one. Maybe in a future interaction I'll try to separate the authentication methods in more de-coupled way (as "components"). Thank you again |
Now that google has deprecated the OpenID login, maybe it's worth reconsidering merging this in? |
@Morgul I have just updated the authentication of Jingo to be able to use the OAuth 2 system (and removed the OpenID 2 altogether). I am still not closing this PR though... still thinking about it :) |
@rushidesai @claudioc @Morgul I think we can move forward creating |
+1 My wife and I own mini pigs and bought the domain Pigipedia.com because there is a distinct lack of factual information on the web about raising mini pigs as house pets. The most helpful info we've gotten is from a smattering of random files members of a Facebook group have uploaded. This Facebook group seems to be the current most popular destination for mini pig owners. I love the simplicity of this wiki so we're going to use it, but to make it easy for Facebook group members to come contribute and help out I'll have to maintain a fork with this PR rolled in so they can use Facebook to authenticate. Not a huge deal, but if this wiki just had some more authentication options someone like me would have zero reason to fork it :) |
A very basic implementation. Also uses Facebook profile picture instead of gravatar.