Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facebook authentication support #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rushidesai
Copy link

A very basic implementation. Also uses Facebook profile picture instead of gravatar.

@claudioc
Copy link
Owner

claudioc commented Dec 6, 2013

Hi @rushidesai and thanks for the PR!

I'm not sure I want to merge it, though... I'd like to maintain the "core" as simple as possible (and you know that those authentication models can break, in the future), using - for now - only the Google login as the "external" one.

Maybe in a future interaction I'll try to separate the authentication methods in more de-coupled way (as "components").

Thank you again

@Morgul
Copy link

Morgul commented May 28, 2014

Now that google has deprecated the OpenID login, maybe it's worth reconsidering merging this in?

@claudioc
Copy link
Owner

@Morgul I have just updated the authentication of Jingo to be able to use the OAuth 2 system (and removed the OpenID 2 altogether).

I am still not closing this PR though... still thinking about it :)

@almereyda
Copy link

@rushidesai @claudioc @Morgul I think we can move forward creating jingo-* plugins on npm. I am also interested in having other authentication systems and am now working on a PR to include Persona within the 24 Pull Requests initiative. I think it doesn't even count as evel as Google and is a proper solution if you only want to have email validation.

@chevcast
Copy link

chevcast commented Sep 8, 2015

+1

My wife and I own mini pigs and bought the domain Pigipedia.com because there is a distinct lack of factual information on the web about raising mini pigs as house pets. The most helpful info we've gotten is from a smattering of random files members of a Facebook group have uploaded. This Facebook group seems to be the current most popular destination for mini pig owners.

I love the simplicity of this wiki so we're going to use it, but to make it easy for Facebook group members to come contribute and help out I'll have to maintain a fork with this PR rolled in so they can use Facebook to authenticate.

Not a huge deal, but if this wiki just had some more authentication options someone like me would have zero reason to fork it :)

yusiwen added a commit to yusiwen/jingo that referenced this pull request Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants