Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental branch] Allow the entity to have a new id #1448

Open
wants to merge 1 commit into
base: experimental
Choose a base branch
from

Conversation

lfades
Copy link

@lfades lfades commented Jul 3, 2024

When the id of the entity is updated from a component I noted that the element wasn't draggable anymore, as it if were not being detected. The reason was that the new id was not being compared in the id effect at Entity.

What I did was to change the effect to read the id from this rather than using the id received by the constructor. This makes sense because the new id is set to the class in the hooks:

useOnValueChange(id, () => (droppable.id = id));

With this change it should be straightforward to add a "Clone" example to the stories. I can do that too if you're interested.

Copy link

changeset-bot bot commented Jul 3, 2024

⚠️ No Changeset found

Latest commit: c42b331

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant