Restrict input types to that get rendered to HTML to not generate HTML errors #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are different editors for text, number, color, url, etc. Also means that default values are checked a bit better than whatever "value" was supposed to mean. Also, how you name your valueType no longer matters and has no side effect in the HTML
|
There are different editors for text, number, color, url, etc. Also means that default values are checked a bit better than whatever "value" was supposed to mean. Also, how you name your valueType no longer matters and has no side effect in the HTML |
clarkmcc
requested changes
Feb 12, 2024
clarkmcc
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled this out and made a draft.