Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework stories and layout #24

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

sroussey
Copy link
Contributor

@sroussey sroussey commented Feb 4, 2024

I should have not mixed these together, but...

This PR:

  1. Moves stories to their own folder
  2. Reworks layout a bit. You need to register a layout before using it. This has a few upsides:
  • The lib does not include dagre and all the requirements, if they are not used.
  • Adding new layouts required changing this lib
  • Easier to force different layout in the layout example rather than just the one, all without needing to change the lib itself
  1. Moves the example node editor out of NodeEditor and into the stories examples.

@sroussey
Copy link
Contributor Author

sroussey commented Feb 4, 2024

This does have a bug though...

In storybook, the first item "Docs" now shows nothing. Not sure how that works.

Copy link
Owner

@clarkmcc clarkmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! One change requested in order for this to be used as an external dependency.

lib/layout/layout.ts Show resolved Hide resolved
@clarkmcc clarkmcc merged commit 50df550 into clarkmcc:main Feb 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants