Some temporary directory handling changes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only canonicalize the temp sandbox directory on macOS, which is critical since `/tmp` is really `/private/tmp`. However, we should do it everywhere, so that tests can actually expect a consistent outcome by looking at `clar_sandbox_path()`.
clar now has the concept of a _temporary directory_, which is the temporary directory for the entirety of a `clar` invocation (a set of test runs) and a sandbox, which is the temporary directory for a single test invocation. This allows us to ensure that a well-written test (that only writes into its sandbox) doesn't poison the well for future test invocations if it fails to clean up its sandbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to temporary directory handling — general quality-of-life changes with an eye toward eventually supporting parallel execution (presumably with separate tempdirs per thread).
canonicalize temp sandbox directory everywhere
We currently only canonicalize the temp sandbox directory on macOS,
which is critical since
/tmpis really/private/tmp. However, weshould do it everywhere, so that tests can actually expect a consistent
outcome by looking at
clar_sandbox_path().tempdir and sandboxes are now separate entities
clar now has the concept of a temporary directory, which is the
temporary directory for the entirety of a
clarinvocation (a set oftest runs) and a sandbox, which is the temporary directory for a single
test invocation.
This allows us to ensure that a well-written test (that only writes into
its sandbox) doesn't poison the well for future test invocations if it
fails to clean up its sandbox.