Permit a complete callback when opening a file

to allow consumers to specify code to always run, after a successful or errorful opening of a file
clalimarmo · Feb 18, 2015 · 2c27a82 · 2c27a82
1 parent bb5bed8
commit 2c27a82
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/dist/json-gcs.js b/dist/json-gcs.js
diff --git a/lib/file.js b/lib/file.js
@@ -46,6 +46,7 @@ define(function() {
           _handlers.success();
         }
       };
+      handlers.complete = _handlers.complete;
       datastore.get(_filename, handlers);
     };
 

diff --git a/lib/storage.js b/lib/storage.js
@@ -70,6 +70,7 @@ define(function(require) {
           data: requestBody,
           success: opts.success,
           error: opts.error,
+          complete: opts.complete,
         }
       );
     };
@@ -89,7 +90,8 @@ define(function(require) {
             }
             handlers.success(json);
           },
-          error: handlers.error
+          error: handlers.error,
+          complete: handlers.complete,
         }
       );
     };

diff --git a/spec/json_gcs_spec.coffee b/spec/json_gcs_spec.coffee
@@ -1,7 +1,7 @@
 define (require) ->
   JsonGCS = require('json-gcs')
 
-  describe 'JsonGCS', ->
+  describe 'JsonGCS.Storage', ->
     mocks = {}
     instance = null
 
@@ -12,7 +12,7 @@ define (require) ->
       }
       mocks.http = {}
 
-      instance = JsonGCS(
+      instance = JsonGCS.Storage(
         http: mocks.http
         authenticator: mocks.authenticator
         bucketName: 'my-bucket'