Skip to content
This repository has been archived by the owner on May 27, 2020. It is now read-only.

Fix build on macOS. #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brndnmtthws
Copy link

The prototypes for cgsleep_ms_r and cgsleep_us_r didn't match the
implementation, and have been updated accordingly.

There's something weird about these functions returning a value, since most of them were void but a couple were returning ints. My guess is that someone needed to debug something and added the code, but never updated the other functions. For the sake of backward compatibility I just added return 0 to the versions returning void.

@jameshilliard
Copy link

FYI anything inside USE_BITMAIN_SOC will never be used on macOS as the bitmain soc driver is strictly linux only.

@jameshilliard
Copy link

I had to ifdef the timing code for that driver since a bisect revealed the newer changes(the timing code not inside USE_BITMAIN_SOC) was causing that driver to fail.

The prototypes for `cgsleep_ms_r` and `cgsleep_us_r` didn't match the
implementation, and have been updated accordingly.
@brndnmtthws
Copy link
Author

@jameshilliard I don't quite understand why the function signatures need to be different. It doesn't make much difference to me in either case.

@jameshilliard
Copy link

Yeah, it may not have been the function signatures that was the issue, I'll try and test these changes when I get some time to verify they don't introduce a regression there.

@metebalci
Copy link

This is also an issue for Windows cross compile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants