Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (engine): Improve performance of the
getModelLength
method.While this looks like a simple change, it introduces significant performance improvements by avoiding recursion and calling
this._viewToModelLengthCallbacks.get()
on nodes without name or when the map is empty (most cases).lists
formatting-long-paragraphs
inline-styles
wiki
We could gain even more performance by removing the public
registerViewToModelLength
method and thethis._viewToModelLengthCallbacks
map, since it's only used in legacy lists, which we are deprecating. However, it's likely that it's used by the integrators and may not be possible. This would improve the performance (on top of proposed changes) offormatting-long-paragraphs
by another 180ms (-4.4%) andinline-styles
by 300ms (-3.8%).