-
Notifications
You must be signed in to change notification settings - Fork 446
Add support for filtering processes by substring. #147
base: master
Are you sure you want to change the base?
Conversation
Press / to input a filter string. The proc list will be filtered to procs that contain the filter as a substring of either the command or the string representation of the PID.
Nice, this is something I've wanted for a while. So a few things I think we should do:
|
Only swallow events that are explicitly handled by the editor. Fall through to the default event handling for all other events. Also, cancel editing on <Escape> and fix README file formatting.
Also, change from [Filter: ...] to Filter: [...].
Great suggestions! Implemented. I reworked the event handling to not swallow events other than those specifically handled. So,
|
Wow, really nice. Quite a few changes so it'll take me a little while to go through. Btw, |
Take your time! I'll stop updating this branch. :) |
I should have clarified earlier that the 3rd commit undoes many of the changes in the first commit. It will probably be easier to review changes from all commits instead of individually reviewing. |
Ping |
Sorry for the silence. This is looking really nice! Seems like all the previous suggestions were implemented. I looked over everything and it LGTM so feel free to add in anything else you've done. One thing is if you could sign #151 and license your additions under MIT that would be great since I'm in the process of relicensing. |
Press / to input a filter string. The proc list will be filtered to
procs that contain the filter as a substring of either the command or
the string representation of the PID.