Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19545 Custom field groups missing from views #405

Open
wants to merge 1 commit into
base: 7.x-master
Choose a base branch
from
Open

CRM-19545 Custom field groups missing from views #405

wants to merge 1 commit into from

Conversation

urlisse
Copy link

@urlisse urlisse commented Oct 19, 2016

Fix for CRM-19545 : "Custom field groups which do not directly extend the base 'Contact' disappear from Drupal view after applying patch CRM-18776"


Fix for CRM-19545 : "Custom field groups which do not directly extend the base 'Contact' disappear from Drupal view after applying patch CRM-18776"
@@ -2911,7 +2911,7 @@ function _civicrm_core_data(&$data, $enabled) {

while ($dao->fetch()) {
// call getTree using $dao->id as groupID, $dao->extends as entityType, with possible subtypes in $dao->extends_entity_column_value
$extendsContactSubtype = (('Contact' === $dao->extends) && !empty($dao->extends_entity_column_value));
$extendsContactSubtype = (in_array($dao->extends, array('Contact', 'Individual', 'Organization', 'Household')) && !empty($dao->extends_entity_column_value));
Copy link
Member

@monishdeb monishdeb Nov 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use CRM_Contact_BAO_ContactType::basicTypePairs() instead, which will consider user-defined contact types and sub-types too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch, and this proposed alteration does not fix the issue for custom fields assigned to Relationships. I'll take a look at an alternative solution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the issue in JIRA with some additional comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants