Generate URLs faster - another attempt #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #88
This one seems to work with the edge cases we were having trouble with:
I have not yet tested the installer or done any benchmarking on speed. Going to do that next.
There's pros and cons to using Civi::cache instead of Civi::statics for storing the menu items, which is the bulk of the problem. It seems to work with either but at the moment I've used cache.
For the known paths, I'm not sure we need to even cache those if we're caching the menu build, but I've left that in.
@MegaphoneJon @jackrabbithanna