[REF] Add in function to retrieve Pre Upgrade messages in headless #25414
Conversation
|
(Standard links)
|
seamuslee001
force-pushed
the
headless_pre_upgrade
branch
from
cf65833
to
40daec2
Compare
|
civibot, test this please |
|
Looks sensible. @seamuslee001 Are you working on a patch for a tool/entry-point that can be used to |
| $upgrade->setPreUpgradeMessage($preUpgradeMessage, $currentVer, $latestVer); | ||
| if (empty($this->preUpgradeMessage)) { | ||
| $preUpgradeMessage = NULL; | ||
| $upgrade->setPreUpgradeMessage($preUpgradeMessage, $currentVer, $latestVer); |
There was a problem hiding this comment.
Ug - this is a bit nasty that it is a pass-by-ref huh? Doesn't look like it is trivial to unravel though
There was a problem hiding this comment.
It is pass by reference
There was a problem hiding this comment.
Yeah, it's also a confusing name... but there are 3 distinct structures which include variations on this signature (CRM_Upgrade_Incremental_Base and its subclasses; then also CRM_Upgrade_Form; then also CRM_Upgrade_Incremental_General).
|
@totten see civicrm/civicrm-drupal#663 I plan to do one for wp-cli as well |
|
Did an |
|
I pulled the merge trigger a bit hastily. Suggested revision: #25488 |
Overview
This makes it possible for CLI tools such as drush and wp cli to get the pre-upgrade message when doing database upgrades
Before
No way to get the pre upgrade messages just post
After
function to get the pre-upgrade message
ping @demeritcowboy @kcristiano @totten