Fix Searchkit "Add" columns button UI #21315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Looks better to me - @colemanw ? |
|
I'm happy with that change but I still think the styling in Shoreditch is problematic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In Search Kit, the Add Columns Button UI has been fixed. Previously it was not visible when using with Shoreditch.
In Response to civicrm/org.civicrm.shoreditch#512.
Before
With Shoreditch
Without Shoreditch
After
With Shoreditch
Without Shoreditch
Technical Details
Previously
btn-default-outlinewas used for the button, which is not correct, because with that class, the Border and Font Color are white. In this case, we need a darker color, since the background is set to white https://github.com/civicrm/civicrm-core/blob/master/ext/search_kit/css/crmSearchAdmin.css#L72.