Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IsVehicleTyreBurst.md (indexes for 8 wheels) #1136

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

iSentrie
Copy link
Contributor

@iSentrie iSentrie commented Jun 24, 2024

Added indexes for vehicles with 8 wheels.

image

image

Added indexes for vehicles with 8 wheels
@AvarianKnight AvarianKnight added the needs validation This looks good, but needs additional confirmation of suggested change. label Aug 6, 2024
Copy link
Contributor

@colistro123 colistro123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks invalid as is to me. Provided feedback.

VEHICLE/IsVehicleTyreBurst.md Outdated Show resolved Hide resolved
@iSentrie
Copy link
Contributor Author

iSentrie commented Aug 6, 2024

Looking deeper in to this, research shows that each game build has different ID's for 2 wheels.

For example:
Build 2802 = 547 / 549
Build 2944 = 412 / 416
Build 3095 = 788 / 792
and so on...

@AvarianKnight
Copy link
Collaborator

Looking deeper in to this, research shows that each game build has different ID's for 2 wheels.

For example: Build 2802 = 547 / 549 Build 2944 = 412 / 416 Build 3095 = 788 / 792 and so on...

Given the fact that these change per game build, I would say that it wasn't intended to work in the first place.

It is probably better to have this as the default enum than trying to update to a magic value every game update, especially considering there are very very few vehicles that will ever need this (iirc it is only this vehicle)

From testing all of these values work on b3258 for the 3rd row of tires:

687 1
1039 1
2170 1
3139 1
3357 1
4630 1

All of these work for 0

0	1
6	1
454	1
510	1
594	1
675	1
1027	1
2146	1
3127	1
3203	1
3351	1
3451	1
3719	1
4040	1
4614	1

There isn't any rhyme or reason these work from a scripting standpoint.

@AvarianKnight AvarianKnight merged commit e92dcdb into citizenfx:master Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs validation This looks good, but needs additional confirmation of suggested change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants