-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document upcoming changes to webhooks payloads #1282
base: master
Are you sure you want to change the base?
Conversation
These are proposed new fields that will come to the payloads and GraphQL API in the coming weeks. These events will allow to improve export of the events into systems like Datadog. See the following issue: * cirruslabs/cirrus-webhooks-server#8 * cirruslabs/cirrus-webhooks-server#9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a timestamp
field for build
's and task
's, similarly to audit_event
's.
Currently, for build
's we only emit a single timestamp, which is build.changeTimestamp
, but it doesn't change when the build gets updated.
For tasks we could use the statusTimestamp
, but it would be nice to have a uniform timestamp
field to avoid ambiguity for the webhook receiver implementors.
@edigaryev what do you think about a request header. Since the payload is a GraphQL query response and I don't think we can add |
That would totally work too. |
These are proposed new fields that will come to the payloads and GraphQL API in the coming weeks.
These events will allow to improve export of the events into systems like Datadog. See the following issue:
timestamp
of the event upon insert cirrus-webhooks-server#8