Update bridged_USDC_standard.md #441
Conversation
v2 of the doc. Updates specifically on the contract details and the token roles.
fix EURC
doc/bridged_USDC_standard.md
Outdated
|
|
||
| The third-party team’s bridge contracts must be upgradeable to add required, specific functionality at a later point in time to support the upgrade steps above, once Circle and the third-party team jointly decide to perform the upgrade. | ||
| The third-party team’s bridge contracts play an integral role and require small additions to support the upgrade process. |
There was a problem hiding this comment.
Q: are we intentionally removing source bridge upgradeability as a requirement?
If not, I feel like this is still an important detail to call out. We should considering specifying the defined interface for burnAllLockedUSDC as well.
There was a problem hiding this comment.
The requirement is specified below on burn, but my understanding is that this doc intends to clarify things before they start deploying, and we recommend them to add the burn functionality after we mutually agree. So they aren't missing out this particular function name particularly. The following two lines hinted some on this regard.
| function transferUSDCRoles(address owner) external; | ||
| ``` | ||
|
|
||
| The function implementation details are left up to the partner, but it must: 1) only be callable by a Circle-owned address and 2) transfer the Implementation Owner role and the ProxyAdmin role to the function caller (if both are assigned to the bridge). |
There was a problem hiding this comment.
Based on how the interface is defined, I believe the ProxyAdmin role will be assigned to the function caller, where as the new owner address should be specified in the function parameter.
function transferUSDCRoles(address owner)
There was a problem hiding this comment.
Yes in some ways we separate these into two function calls (they transfer the proxyAdmin to us first, and they call this function to transfer the owner role to us which we move the remaining roles).
The goal for this doc isn't to specify the upgrade process which often times requires more digging and isn't something we want every team to be ready to do before we agree to convert. What we can do is to make sure that they don't hit the problems when deploying bridged token that makes it impossible for future upgrade. This doc shouldn't describe the upgrade process in that level of detail.
Do you agree @mauriziocircle
update some wording.
v2 of the doc. Updates specifically on the contract details and the token roles.
Summary
Added more clarity on contract details and token roles in this v2 of the doc.
Detail
As summary.
Testing
NA
Documentation
That's this PR's main change.