Fiat Token v2.2 #425
Merged
Fiat Token v2.2 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setup and test CI * Fix new line * Lock node version * Fix new line and add PR template * Address feedback * Remove unused files
* Add test to make sure DOMAIN_SEPARATOR slot stays at 15 * Override DOMAIN_SEPARATOR to detect when chainid has changed * Add contract size plugin * Add mock fiat token class to test all branches * Reduce solc warnings and update license * Add contract size command * Minor edits with husky * Update yarn.lock * Update contract version in comments * Recalculate domain separator every time --------- Co-authored-by: Erik Tierney <[email protected]>
* Add V2_2Upgrader * Fixed tests * Fix typecheck and update CI * Fix yarn check * Update upgrader and tests * Add domainSeparator to check * Update comment * Address feedback * Also check rescuer, paused and totalSupply * Rename to checkFiatTokenMetadataEqual * Add description to upgrader * Remove withdrawUSDC and update test * Update docs to reference a yarn script instead
* Remove references to USDC * Fix solhint * Create AbstractV2Upgrader * Refactor tearDown * Update comments * Remove migrate scripts * Update docs * Update natspec and remove unused import * Update helpers * Remove V2_1UpgraderHelper
* Add EIP-1271 related utility contracts * Update package.json * Clarify documentation and address minor PR comments * Include the magic value in IERC1271 return value description * Add test case to demonstrate behavior of state modifying wallet * Modify test description * Rename MockMaliciousERC1271Wallet * Rename wallet variables * Address nits
* Re-route EIP-2612 and EIP-3009 functions to use SignatureChecker * Add @dev docs to specify signature packing order
* Add unified interface for EOA and contract wallet signatures * Modify comment
* Rename blacklist mapping to _deprecatedBlacklisted * Rename balances to balanceAndBlacklistStates * Rename balances to balanceAndBlacklistStates * Replace _deprecatedBlacklisted
* Update Blacklistable methods * Update FiatTokenV1 implementations * Rename and refactor methods * Update storageSlots test * Update misc test * Update unit tests * Add FiatTokenV2_2 tests * Fix test * Fix ci * Allow unlimited contract size on Ganache * Update contract size check * Change blacklist file and add comment about test file * Fix copyright headers in PR * Update NatSpec docs * Also remove proxy from deprecatedBlacklisted * Update _setBalance
* Remove unused imports * Fix additional solhint warnings
* Remove blacklist modifier from approve, permit, and increase/decreaseAllowance * Update unit tests * Update comments * Address nits * Update documentations
* Update/add NatSpec comments * Replace references to USDC * Address comment * Tiny grammar fixes
* Centralize ganache accounts initialization * Delete unnecessary exports from TokenTestUtils * Improve import
* Add script to get blacklisted accounts * Update files to JSON instead of JS * Output to .remote.json instead * Update doc and add script to get contract creation block number * Fix script * Use Blacklistable abi instead
* Centralize static hex values in constants * Organize hex and bn values * Remove the rest of the TODOs * Remove redundant import/export
* Add script to call read-only functions on a contract * Update upgrader doc * Move address definition out and remove redundant func abstraction * Update JSDoc * kebab-ify script args
* Create script to deploy MockERC1271Wallet * Modify config.js * Update documentation for testing sample ERC1271 wallet * Update v2.2 doc
* Update LICENSE * Update licenser format * Update licence headers --- Co-authored-by: Aloysius Chan <[email protected]>
* Update centrehq to circlefin * Update centre-tokens references * Remove typo * Update more docs * Organize README * Add more content * Add reference to OZ Proxy Upgrade Pattern
* Add migration option to directly deploy v2.2 token * Minor modification to migration script * Update copyright headers for new files * Minor changes to deploy scripts
* Update validateAccountsToBlacklist * Add rebase script * Add diff checker * Update validateAccountsToBlacklist * Update validateAccountsToBlacklist * Address feedback * Tiny fix to duplicate validation
* Add changelog
mboorstin-circle
approved these changes
Nov 9, 2023
walkerq
approved these changes
Nov 9, 2023
eztierney
approved these changes
Nov 9, 2023
grantmike
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains a series of backwards-compatible changes for version 2.2 of the Fiat Token smart contracts. Over the upcoming months, the new implementation will be deployed to all Circle-issued stablecoins, including USDC and EURC, across all EVM-compatible blockchains currently supported by Circle.
Please reference the CHANGELOG to get a brief overview of the proposed improvements. For more comprehensive insights into each of these changes and the rationale behind them, we invite you to read the v2.2 launch blog post.