-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and candy generator #774
Merged
renaudpawlak
merged 24 commits into
cincheo:develop
from
kohlschutter:ck/UpdateDependenciesAndCandyGenerator
Oct 15, 2023
Merged
Update dependencies and candy generator #774
renaudpawlak
merged 24 commits into
cincheo:develop
from
kohlschutter:ck/UpdateDependenciesAndCandyGenerator
Oct 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define plugin dependency version at the top-level POM.
This is code can trivially be integrated as an implementation detail into candy generator. Eventually, it can be replaced by standard Java API code, but now is not the time.
Maven dependencies should be managed centrally for the entire project.
candy-generator: Util: check for null (XXX)
Remove mockito-core, which wasn't used.
Previously, we were building the used parsers with an Ant script. This was brittle, especially updating dependency versions was difficult. Moreover, the generated files contained timestamps, which is why these files were not included in version control. Replace the generator builder code with a Java class that gets executed upon Maven build. The generator automatically transforms the output to remove all information about the current timestamp, making it possible to include the files in version control. This also helps checking for errors when updating the parser generators.
Update generated parser code. Clarify Licenses in pom.
... and replace obsoleted methods as described in jsoup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn versions:display-dependency-updates -U
andmvn versions:display-plugin-updates -U