tetra: Added dynamic log level change option #2643
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a tetra loglevel subcommand which allows one to dynamically change Tetragon's log level without restarting it. Signed-off-by: Philip Schmid <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jrfastab
reviewed
Jul 12, 2024
| } | ||
|
|
||
| // Temporarily set the logger to the lowest level to ensure the message is logged | ||
| logger.SetLogLevel(logrus.TraceLevel) |
There was a problem hiding this comment.
Will this impact other routines also using logger here? I'm not sure about internals of logging but we wouldn't want to shortly spew debug/trace info if another sensor is running.
Why not just make it a Warn if its critical to have printed? Seems cleaner than bouncing loglevel around.
jrfastab
reviewed
Jul 12, 2024
| } | ||
|
|
||
| func (s *Server) ResetLogLevel(ctx context.Context, req *tetragon.ResetLogLevelRequest) (*tetragon.ResetLogLevelResponse, error) { | ||
| // TODO: Get the original log level with which Tetragon was originally started with in a nicer way than via "option.Config.LogOpts["level"]". |
There was a problem hiding this comment.
I would either drop the todo and create a first issue or do this ;)
|
Like the idea started reviewing before I noticed it was draft. But would be a good addition thanks for working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a tetra loglevel subcommand which allows one to dynamically change Tetragon's log level without restarting it.
Supported subcommands:
get Prints the current log level reset Reset the log level to the value Tetragon was started with set Set the log levelFixes: #2545