added ?T option to run-tests.sh #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and recaptured the outputs
pkhanpara
changed the title
|
We will need test for highlighting, but that could be another issue to keep this minimal. Looks good, but tests are failing. Probably escaping got wrong at some point so the server returns StackOverflow answers instead of stored data. |
|
I've fixed the escaping. Now it may show one unrelated test failing in both modes, which looks like a different issue. And there is one more unrelated test failing in standalone mode. |
|
@chubin what do you think about suppressing colors in tests? Feel free to point out an alternative approach if you don't feel like this is the right way to do it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ?T option to run-tests.sh to ignore ansi styling mismatch errors and recaptured the outputs. Fixing #345