Address some test flakiness

chrisvest · Jun 9, 2024 · 9749747 · 9749747
1 parent b5fe1cb
commit 9749747
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/test/java/blackbox/ThreadBasedPoolTest.java b/src/test/java/blackbox/ThreadBasedPoolTest.java
@@ -720,4 +720,10 @@ void tryClaimMustReturnIfPoolIsNotEmpty(Taps taps) throws Exception {
     noBackgroundExpirationChecking();
     super.tryClaimMustReturnIfPoolIsNotEmpty(taps);
   }
+
+  @Override
+  void managedPoolMustGiveNumberOfAllocatedAndInUseObjects() throws Exception {
+    noBackgroundExpirationChecking();
+    super.managedPoolMustGiveNumberOfAllocatedAndInUseObjects();
+  }
 }
diff --git a/src/test/java/blackbox/slow/PoolIT.java b/src/test/java/blackbox/slow/PoolIT.java
@@ -20,6 +20,7 @@
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInfo;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import stormpot.Completion;
@@ -88,8 +89,9 @@ void setUp() {
   protected abstract PoolBuilder<GenericPoolable> createPoolBuilder(CountingAllocator allocator);
 
   @AfterEach
-  void verifyObjectsAreNeverDeallocatedMoreThanOnce() throws InterruptedException {
-    assertTrue(pool.shutdown().await(shortTimeout), "pool should have been shut down by the test");
+  void verifyObjectsAreNeverDeallocatedMoreThanOnce(TestInfo info) throws InterruptedException {
+    assertTrue(pool.shutdown().await(shortTimeout),
+            "pool should have been shut down by the test: " + info.getDisplayName());
     pool = null;
 
     List<GenericPoolable> deallocated = allocator.getDeallocations();