CheckUnusedVar: fixed potential crash with incomplete code in `doAssi…

…gnment()` (danmar#5887) Happened with the IDE integration while I was typing code.
chrchr-github · Jan 17, 2024 · c5b50ed · c5b50ed
1 parent 9c1b643
commit c5b50ed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/checkunusedvar.cpp b/lib/checkunusedvar.cpp
@@ -474,6 +474,8 @@ static const Token* doAssignment(Variables &variables, const Token *tok, bool de
                     tok = tok->next();
 
                 tok = tok->next();
+                if (!tok)
+                    return tokOld;
                 if (tok->str() == "*")
                     tok = tok->next();
 

diff --git a/test/testgarbage.cpp b/test/testgarbage.cpp
@@ -252,6 +252,7 @@ class TestGarbage : public TestFixture {
         TEST_CASE(garbageCode221);
         TEST_CASE(garbageCode222); // #10763
         TEST_CASE(garbageCode223); // #11639
+        TEST_CASE(garbageCode224);
 
         TEST_CASE(garbageCodeFuzzerClientMode1); // test cases created with the fuzzer client, mode 1
 
@@ -1719,6 +1720,9 @@ class TestGarbage : public TestFixture {
     void garbageCode223() { // #11639
         ASSERT_THROW(checkCode("struct{}*"), InternalError);  // don't crash
     }
+    void garbageCode224() {
+        checkCode("void f(){ auto* b = dynamic_cast<const }");  // don't crash
+    }
 
     void syntaxErrorFirstToken() {
         ASSERT_THROW(checkCode("&operator(){[]};"), InternalError); // #7818