Fix autovarInvalidDeallocation regression

chrchr-github · Jun 27, 2023 · a110fa0 · a110fa0
1 parent 9dc38f8
commit a110fa0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/checkautovariables.cpp b/lib/checkautovariables.cpp
@@ -303,7 +303,7 @@ void CheckAutoVariables::autoVariables()
                         if (v.isImpossible())
                             continue;
                         if ((v.isTokValue() && (isArrayVar(v.tokvalue) || ((v.tokvalue->tokType() == Token::eString)))) ||
-                            (v.isLocalLifetimeValue() && v.lifetimeKind == ValueFlow::Value::LifetimeKind::Address)) {
+                            (v.isLocalLifetimeValue() && v.lifetimeKind == ValueFlow::Value::LifetimeKind::Address && !Token::simpleMatch(v.tokvalue, "("))) {
                             errorInvalidDeallocation(tok, &v);
                             break;
                         }

diff --git a/test/testautovariables.cpp b/test/testautovariables.cpp
@@ -847,6 +847,12 @@ class TestAutoVariables : public TestFixture {
               "    return 0;\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("void f() {\n"
+              "    S* p = &g();\n"
+              "    delete p;\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void testinvaliddealloc_input() {