Fix #12473 FN uninitvar with pointer member (regression) (danmar#6039)

chrchr-github · Feb 26, 2024 · 91f15aa · 91f15aa
1 parent 950e894
commit 91f15aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/checkuninitvar.cpp b/lib/checkuninitvar.cpp
@@ -1658,7 +1658,7 @@ void CheckUninitVar::valueFlowUninit()
                     (!isVariableChangedByFunctionCall(v->tokvalue, v->indirect, mSettings, &inconclusive) || inconclusive))
                     continue;
                 if (usage != ExprUsage::Used) {
-                    if (!(Token::Match(tok->astParent(), ". %name% (") && uninitderef) &&
+                    if (!(Token::Match(tok->astParent(), ". %name% (|[") && uninitderef) &&
                         isVariableChanged(tok, v->indirect, mSettings, mTokenizer->isCPP()))
                         continue;
                     if (isVariableChangedByFunctionCall(tok, v->indirect, mSettings, &inconclusive) || inconclusive)

diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -6414,6 +6414,13 @@ class TestUninitVar : public TestFixture {
                         "    return s[0].x;\n"
                         "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        valueFlowUninit("struct S { int* p; };\n" // #12473
+                        "void f() {\n"
+                        "    struct S s;\n"
+                        "    s.p[0] = 0;\n"
+                        "}\n");
+        ASSERT_EQUALS("[test.cpp:4]: (error) Uninitialized variable: s.p\n", errout.str());
     }
 
     void valueFlowUninitBreak() { // Do not show duplicate warnings about the same uninitialized value