Fix #13026 (Fix Coverity issues) (danmar#6710)

chrchr-github · Aug 21, 2024 · 426c621 · 426c621
1 parent 2c2d504
commit 426c621
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/checkunusedvar.cpp b/lib/checkunusedvar.cpp
@@ -1595,7 +1595,7 @@ bool CheckUnusedVar::isRecordTypeWithoutSideEffects(const Type* type)
             continue; // ignore default/deleted constructors
         const bool emptyBody = (f.functionScope && Token::simpleMatch(f.functionScope->bodyStart, "{ }"));
 
-        const Token* nextToken = f.argDef->link();
+        const Token* nextToken = f.argDef ? f.argDef->link() : nullptr;
         if (Token::simpleMatch(nextToken, ") :")) {
             // validating initialization list
             nextToken = nextToken->next(); // goto ":"

diff --git a/lib/path.cpp b/lib/path.cpp
@@ -164,7 +164,8 @@ std::string Path::getCurrentExecutablePath(const char* fallback)
 #else // Linux
         "/proc/self/exe";
 #endif
-    success = (readlink(procPath, buf, sizeof(buf)) != -1);
+    // readlink does not null-terminate the string if the buffer is too small, therefore write bufsize - 1
+    success = (readlink(procPath, buf, sizeof(buf) - 1) != -1);
 #endif
     return success ? std::string(buf) : std::string(fallback);
 }