Fix danmar#4478: FP: Uninitialized variable (danmar#6493)

chrchr-github · Jun 8, 2024 · 3e54980 · 3e54980
1 parent f1ddd1a
commit 3e54980
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -3415,6 +3415,8 @@ ExprUsage getExprUsage(const Token* tok, int indirect, const Settings& settings)
         if (isUsedAsBool(tok, settings))
             return ExprUsage::NotUsed;
     }
+    if (tok->isUnaryOp("&") && !parent)
+        return ExprUsage::NotUsed;
     if (indirect == 0) {
         if (Token::Match(parent, "%cop%|%assign%|++|--") && parent->str() != "=" &&
             !parent->isUnaryOp("&") &&

diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -4304,7 +4304,7 @@ class TestUninitVar : public TestFixture {
                         "    long a;\n"
                         "    &a;\n"
                         "}");
-        TODO_ASSERT_EQUALS("", "[test.cpp:3]: (error) Uninitialized variable: &a\n", errout_str());
+        ASSERT_EQUALS("", errout_str());
 
         valueFlowUninit("void f() {\n" // #4717 - ({})
                         "    int a = ({ long b = (long)(123); 2 + b; });\n"