Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Dont build MSI on the support branch #3580

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Dec 3, 2024

Description Of Changes

Skip attempting to build an MSI on the support branch as there is no MSI to build.

This PR also converts the recipe.cake file to CRLF line endings so that it matches the line endings on the develop branch and doesn't fight the .editorconfig file.

Motivation and Context

There is no MSI on this branch, so the task will fail.

Testing

Locally ran ./build.official.bat --verbosity=diagnostic --target=CI --testExecutionType=unit --shouldRunOpenCover=false --shouldBuildMsi=true and verified that it ran successfully.

Operating Systems Testing

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

The default build on TeamCity will build an MSI. This branch does not
have an MSI project. This sets the task that would build the MSI to not
be run at all on this branch. # Please enter the commit message for your
changes. Lines starting
@corbob corbob added BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. labels Dec 3, 2024
@corbob corbob requested a review from vexx32 December 3, 2024 01:04
@corbob corbob self-assigned this Dec 3, 2024
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vexx32 vexx32 merged commit bbde1a1 into chocolatey:hotfix/1.4.1 Dec 3, 2024
5 checks passed
@corbob corbob deleted the dont-build-msi branch December 3, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants