Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3565) Update tests to be able to push when anonymous access is disabled. #3576

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Nov 27, 2024

Description Of Changes

Add the push source to configuration so that we are able to push to it
successfully. When anonymous access is disabled, Chocolatey will now
only use credentials it has configured by the exact source URL, and not
just one that matches the hostname. As such, this test started failing
and needs to be updated to ensure the credentials can be used.

See #2026 for more details.

Motivation and Context

Ensure tests that were failing can now pass.

Testing

Run the PushCommand tag in Test Kitchen.

Operating Systems Testing

  • Windows Server 2016
  • Windows Server 2019

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Pester tests

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Add the push source to configuration so that we are able to push to it
successfully. When anonymous access is disabled, Chocolatey will now
only use credentials it has configured by the exact source URL, and not
just one that matches the hostname. As such, this test started failing
and needs to be updated to ensure the credentials can be used.

See chocolatey#2026 for more details.
Correct the Licensed version capture so that the regex matches when
Licensed Extension with User Agent update is installed. Also adds a
validation that the LicensedVersion is present when Licensed Extension
is installed.
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit b9ef43f into chocolatey:hotfix/2.4.1 Nov 29, 2024
5 checks passed
@AdmiringWorm
Copy link
Member

@corbob thanks for getting this test fixed. Great work.

@corbob corbob deleted the minor-test-fix branch November 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants