Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#407) Retain Astro Component CSS #408

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Jun 12, 2024

Description Of Changes

The purgeCSS flow has been adjusted to ensure that
any classes on Astro Components are retained. This
ensures that the Astro Components are styled
correctly.

In addition, this is now checking for a value
when trigger automation for tabs with a multi
version. This ensures no invalid JSON errors.

Motivation and Context

We want Astro Components to render correctly.

Testing

See steps on PR: chocolatey/docs#1008

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #407

The purgeCSS flow has been adjusted to ensure that
any classes on Astro Components are retained. This
ensures that the Astro Components are styled
correctly.

In addition, this is now checking for a value
when trigger automation for tabs with a multi
version. This ensures no invalid JSON errors.
@st3phhays st3phhays marked this pull request as ready for review June 12, 2024 18:42
@st3phhays st3phhays self-assigned this Jun 12, 2024
Comment on lines +72 to +73
'node_modules/choco-astro/src/**/*.astro',
'node_modules/choco-astro/src/**/*.ts'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steviecoaster These are the main changes. Most of everything else are auto generated files as a result of updating choco-theme to a new version.

Copy link
Contributor

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steviecoaster steviecoaster merged commit 2188941 into chocolatey:main Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS for Astro Components Purged
2 participants