-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#405) (ENGTASKS-3631) Support Astro Framework #404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in draft because it will need to be tested against docs before merged. |
st3phhays
force-pushed
the
astro
branch
2 times, most recently
from
May 21, 2024 18:10
35be37c
to
2f1d480
Compare
st3phhays
changed the title
(#405) Support Astro Framework
(#405) Support Astro Framework (ENGTASKS-3631)
Jun 4, 2024
st3phhays
changed the title
(#405) Support Astro Framework (ENGTASKS-3631)
(#405) (ENGTASKS-3631) Support Astro Framework
Jun 4, 2024
st3phhays
changed the title
(#405) (ENGTASKS-3631) Support Astro Framework
(#405)(ENGTASKS-3631) Support Astro Framework
Jun 4, 2024
st3phhays
changed the title
(#405)(ENGTASKS-3631) Support Astro Framework
(#405) (ENGTASKS-3631) Support Astro Framework
Jun 4, 2024
st3phhays
force-pushed
the
astro
branch
2 times, most recently
from
June 6, 2024 16:42
c52ff67
to
8dacc12
Compare
st3phhays
force-pushed
the
astro
branch
4 times, most recently
from
June 8, 2024 20:00
d05a2b8
to
b1a3c36
Compare
st3phhays
added
3 - Review
Code has been added, and is available for review as a pull request
and removed
3 - Review
Code has been added, and is available for review as a pull request
labels
Jun 8, 2024
gep13
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The changes here are needed in order to support the Astro framework. A few styles were updated, but the majority of the changes are in the build process and some updates to converted markdown inside code blocks. All existing choco-theme commands still work and are ran the same way from the command line, except now when running anything with `--docs` it will run Astro commands instead of a preview.sh or preview.ps1 file.
@st3phhays looking forward to see this new version in action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The changes here are needed in order to support
the Astro framework. A few styles were updated,
but the majority of the changes are in the build
process and some updates to converted markdown
inside code blocks. All existing choco-theme
commands still work and are ran the same way from
the command line, except now when running anything
with
--docs
it will run Astro commands insteadof a preview.sh or preview.ps1 file.
Motivation and Context
These are all needed to support the Astro Framework.
Testing
TBD.
Change Types Made
Change Checklist
Related Issue