Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#405) (ENGTASKS-3631) Support Astro Framework #404

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented May 14, 2024

Description Of Changes

The changes here are needed in order to support
the Astro framework. A few styles were updated,
but the majority of the changes are in the build
process and some updates to converted markdown
inside code blocks. All existing choco-theme
commands still work and are ran the same way from
the command line, except now when running anything
with --docs it will run Astro commands instead
of a preview.sh or preview.ps1 file.

Motivation and Context

These are all needed to support the Astro Framework.

Testing

TBD.

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@st3phhays st3phhays changed the title WIP Astro (#405) Support Astro Framework May 17, 2024
@st3phhays st3phhays marked this pull request as draft May 17, 2024 18:11
@st3phhays st3phhays self-assigned this May 17, 2024
@st3phhays
Copy link
Member Author

This is in draft because it will need to be tested against docs before merged.

@st3phhays st3phhays force-pushed the astro branch 2 times, most recently from 35be37c to 2f1d480 Compare May 21, 2024 18:10
@st3phhays st3phhays changed the title (#405) Support Astro Framework (#405) Support Astro Framework (ENGTASKS-3631) Jun 4, 2024
@st3phhays st3phhays changed the title (#405) Support Astro Framework (ENGTASKS-3631) (#405) (ENGTASKS-3631) Support Astro Framework Jun 4, 2024
@st3phhays st3phhays changed the title (#405) (ENGTASKS-3631) Support Astro Framework (#405)(ENGTASKS-3631) Support Astro Framework Jun 4, 2024
@st3phhays st3phhays changed the title (#405)(ENGTASKS-3631) Support Astro Framework (#405) (ENGTASKS-3631) Support Astro Framework Jun 4, 2024
@st3phhays st3phhays force-pushed the astro branch 2 times, most recently from c52ff67 to 8dacc12 Compare June 6, 2024 16:42
@st3phhays st3phhays requested a review from gep13 June 6, 2024 18:34
@st3phhays st3phhays force-pushed the astro branch 4 times, most recently from d05a2b8 to b1a3c36 Compare June 8, 2024 20:00
@st3phhays st3phhays added 3 - Review Code has been added, and is available for review as a pull request and removed 3 - Review Code has been added, and is available for review as a pull request labels Jun 8, 2024
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The changes here are needed in order to support
the Astro framework. A few styles were updated,
but the majority of the changes are in the build
process and some updates to converted markdown
inside code blocks. All existing choco-theme
commands still work and are ran the same way from
the command line, except now when running anything
with `--docs` it will run Astro commands instead
of a preview.sh or preview.ps1 file.
@st3phhays st3phhays marked this pull request as ready for review June 11, 2024 21:10
@gep13 gep13 merged commit 26b4eaf into chocolatey:main Jun 12, 2024
3 checks passed
@gep13
Copy link
Member

gep13 commented Jun 12, 2024

@st3phhays looking forward to see this new version in action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants