Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#351) Allow Standard Support at < 100 nodes #352

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Aug 2, 2023

Description Of Changes

This allows the Standard Support option to be selected at < 100 nodes, but still places it as an add-on until the node count is >= 100.

Motivation and Context

This should be able to to be selected with < 100 nodes.

Testing

  1. Run the PR at https://github.com/chocolatey/chocolatey.org/pull/269
  2. Run the playwright test once the website is running yarn run playwright.
  3. If wanted, on the home page, manually slide or input 33 nodes and observe how the Standard Support option is still available to select and is not disabled.
    1. Click the Standard Support option, it is added to the Add On Container on the right and the price is adjusted.

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

This allows the Standard Support option to be selected at < 100 nodes,
but still places it as an add-on until the node count is >= 100.
@st3phhays
Copy link
Member Author

If this looks good, it can be merged.

@st3phhays st3phhays requested a review from corbob August 2, 2023 16:20
@corbob corbob merged commit 3ca06e9 into chocolatey:main Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants