Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#344) Introduce Pricing Calculator on Home Page #345

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Jun 21, 2023

Description Of Changes

A pricing calculator has been added to the home page. This calculator allows users to select the number of nodes, support level, and Custom Packaging credits to determine the cost of Chocolatey for Business.

This calculator is likely to go on other pages of chocolatey.org in the future.

This introduces Playwright for UI testing. All test are imported into
the associated repository with that repositories gulpfile.js. Commands
to run these tests will be added to the repositories README file as
well. Right now, this introduces tests for the new pricing calculator.
This will test things like ensuring modals pop up, price points are
correct, and listed included items are shown for each bracket.

Motivation and Context

This will enable users to get a more accurate idea of what Chocolatey for Business will cost for them.

Testing

  1. This should be tested by running the PR on chocolatey.org at https://github.com/chocolatey/chocolatey.org/pull/263. Follow the instructions on that PR.

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@st3phhays st3phhays self-assigned this Jun 21, 2023
@st3phhays st3phhays force-pushed the home-pricing branch 3 times, most recently from 7952aac to 3b964be Compare June 27, 2023 16:07
@st3phhays st3phhays force-pushed the home-pricing branch 3 times, most recently from 3265a05 to 36ff9e9 Compare July 14, 2023 15:39
@st3phhays st3phhays force-pushed the home-pricing branch 5 times, most recently from 07c8f8e to 5082c49 Compare July 18, 2023 00:54
@st3phhays st3phhays requested review from AdmiringWorm and corbob and removed request for corbob July 21, 2023 13:28
@st3phhays st3phhays requested a review from vexx32 July 24, 2023 14:45
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small questions, otherwise this looks good :3

.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
A pricing calculator has been added to the home page. This calculator
allows users to select the number of nodes, support level, and Custom
Packaging credits to determine the cost of Chocolatey for Business.

This calculator is likely to go on other pages of chocolatey.org in the
future.
This introduces Playwright for UI testing. All test are imported into
the associated repository with that repositories gulpfile.js. Commands
to run these tests will be added to the repositories README file as
well. Right now, this introduces tests for the new pricing calculator.
This will test things like ensuring modals pop up, price points are
correct, and listed included items are shown for each bracket.
@st3phhays st3phhays marked this pull request as ready for review July 28, 2023 15:36
@st3phhays
Copy link
Member Author

I've added a commit to bump the choco-theme version here so we can get it updated on the chocolatey.org PR.

Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Great work, Steph! 💖

@vexx32 vexx32 merged commit bd9afcb into chocolatey:main Jul 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants