Make code PHP8.1 compatible #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Remove optional arguments before required arguments. Fix: Return types for Walker.
aik099
requested changes
Oct 10, 2024
| @@ -149,7 +149,7 @@ public function push($jql, $fields = null) | |||
| * @return mixed Can return any type. | |||
| * @link http://php.net/manual/en/iterator.current.php | |||
| */ | |||
| public function current() | |||
| public function current(): mixed | |||
There was a problem hiding this comment.
I understand that in PHP 8.1 (or even in PHP 8.0) the Iterator interface method signatures were changed. Due to that change, I see no way to have the same iterator class declaration, that will satisfy every supported PHP version (5.x, 7.x, 8.x).
Do you see any way to make this work?
P.S.
This code changes causes lot of builds to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Remove optional arguments before required arguments.
Fix: Return types for Walker.