log: avoid setting default slog logger in init (ethereum#28747)

slog.SetDefault has undesirable side effects. It also sets the default logger destination, for example. So we should not call it by default in init.
chinyuchan · Dec 30, 2023 · c053eb7 · c053eb7
1 parent 76a5474
commit c053eb7
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/log/root.go b/log/root.go
@@ -10,8 +10,7 @@ import (
 var root atomic.Value
 
 func init() {
-	defaultLogger := &logger{slog.New(DiscardHandler())}
-	SetDefault(defaultLogger)
+	root.Store(&logger{slog.New(DiscardHandler())})
 }
 
 // SetDefault sets the default global logger