Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: option to fall through to middleware chain on source 404 (#248) #390

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aral
Copy link

@aral aral commented Jan 26, 2020

By default, the proxy handles all requested routes on the given context(s), even if they are 404. This makes sense for routes that are actually handled by the target but there is a use case where it would be useful to be able to fall-through to the middleware chain if the target cannot handle the request. This would allow, for example, for a server’s functionality to be extended by another server.

This merge request adds a fallthrough option. When present, any 404 errors fall through to the middleware stack of the server by calling next().

Context: #248

@ghost
Copy link

ghost commented Jan 26, 2020

DeepCode's analysis on #30855c found:

  • 0 critical issues. ⚠️ 0 warnings and 3 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant