Removed dead code #101
Open
Removed dead code #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless I'm mistaken, there is no way that `value` can be an instance of ConfigList or ConfigTree. `ConfigList` is a subclass of `list`, `ConfigTree` is a subclass of `OrderedDict`. There are no assignments to `os.environ`, nor can these types be assigned to `os.environ` anyway. See http://stackoverflow.com/questions/39949587/can-python-os-environ-get-ever-return-a-non-string for a discussion.
|
cc @darthbear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm mistaken, there is no way that
valuecan be an instance of ConfigList or ConfigTree.ConfigListis a subclass oflist,ConfigTreeis a subclass ofOrderedDict.There are no assignments to
os.environ, nor can these types be assigned toos.environanyway.See http://stackoverflow.com/questions/39949587/can-python-os-environ-get-ever-return-a-non-string for a discussion.